SPINBOX - strange behaviour

    This site uses cookies. By continuing to browse this site, you are agreeing to our Cookie Policy.

    • SPINBOX - strange behaviour

      Hello.

      I would like to understand if there is the strange behaviour of SPINBOX or I do something wrong.

      In attachment - source code (on base of demo-code of SPINBOX-widget).

      I have added a BUTTON (id GUI_ID_BUTTON0) for disable/enable SPINBOX-widget (id GUI_ID_SPINBOX2) by its cklicking.
      But If you run this sample you will see, that the state disable/enable of this SPINBOX-widget is changed by cklicking on every widget, even from itself.

      The code of enable/disable by pressing BUTTON starts from line 39.
      And this code gets entry by pressing of ALL widgets, not only by BUTTON with id GUI_ID_BUTTON0.

      And why if I click right arrow of SPINBOX with id GUI_ID_SPINBOX2 it starts increasing continuously?

      C Source Code

      1. #include "GUI.h"
      2. #include "DIALOG.h"
      4. static const GUI_WIDGET_CREATE_INFO _aDialogSpinbox[] = {
      5. { FRAMEWIN_CreateIndirect, "Spinbox", 0, 0, 0, 320, 240, 0, 0, 0 },
      6. { SPINBOX_CreateIndirect, NULL, GUI_ID_SPINBOX0, 10, 15, 60, 21, 0, 0, 0 },
      7. { SPINBOX_CreateIndirect, NULL, GUI_ID_SPINBOX1, 10, 42, 60, 21, 0, 0, 0 },
      8. { SPINBOX_CreateIndirect, NULL, GUI_ID_SPINBOX2, 10, 75, 220, 80, 0, 0, 0 },
      9. { BUTTON_CreateIndirect, "Click", GUI_ID_BUTTON0, 10, 170, 80, 24, 0, 0, 0 },
      10. };
      12. static void _cb(WM_MESSAGE * pMsg) {
      13. EDIT_Handle hEdit;
      14. WM_HWIN hItem;
      15. int Value;
      16. int NCode;
      17. int Id;
      19. switch (pMsg->MsgId) {
      21. case WM_INIT_DIALOG:
      22. hItem = WM_GetDialogItem(pMsg->hWin, GUI_ID_SPINBOX0);
      23. hEdit = SPINBOX_GetEditHandle(hItem);
      24. EDIT_SetDecMode(hEdit, 1, 1, 10, 0, 0);
      25. hItem = WM_GetDialogItem(pMsg->hWin, GUI_ID_SPINBOX1);
      26. hEdit = SPINBOX_GetEditHandle(hItem);
      27. EDIT_SetDecMode(hEdit, 1, 0, 99999, 0, 0);
      28. hItem = WM_GetDialogItem(pMsg->hWin, GUI_ID_SPINBOX2);
      29. SPINBOX_SetEdge(hItem, SPINBOX_EDGE_CENTER);
      30. SPINBOX_SetEditMode(hItem, SPINBOX_EM_EDIT);
      31. SPINBOX_SetRange(hItem, 0, 99999);
      32. break;
      34. case WM_NOTIFY_PARENT:
      35. NCode = pMsg->Data.v;
      36. Id = WM_GetId(pMsg->hWinSrc);
      37. switch (NCode) {
      38. case WM_NOTIFICATION_CLICKED:
      39. if (Id = GUI_ID_BUTTON0) {
      40. hItem = WM_GetDialogItem(pMsg->hWin, GUI_ID_SPINBOX2);
      41. WM_SetEnableState(hItem, !WM_IsEnabled(hItem));
      42. }
      43. break;
      44. case WM_NOTIFICATION_VALUE_CHANGED:
      45. if (Id == GUI_ID_SPINBOX0) {
      46. Value = SPINBOX_GetValue(pMsg->hWinSrc);
      47. hItem = WM_GetDialogItem(pMsg->hWin, GUI_ID_SPINBOX1);
      48. SPINBOX_SetStep(hItem, Value);
      49. }
      50. break;
      51. default:
      52. WM_DefaultProc(pMsg);
      53. }
      54. break;
      56. default:
      57. WM_DefaultProc(pMsg);
      58. }
      59. }
      61. void MainTask(void) {
      62. GUI_Init();
      63. GUI_CreateDialogBox(_aDialogSpinbox, GUI_COUNTOF(_aDialogSpinbox), _cb, WM_HBKWIN, 30, 30);
      64. while (1) {
      65. GUI_Delay(100);
      66. }
      67. }
      Display All
      Best regards,
      Volodymyr.

    • Hi Volodymyr,

      the error lies in line 39. It should be "Id == GUI_ID_BUTTON0" instead of "Id = GUI_ID_BUTTON0". Now you just set the Id variable and the if-clause checks if Id is not zero, so you always land in that case. A tiny but weighty error, took me a while until I saw it, too...

      I'd advise you to call WM_InvalidateWindow(hItem); after you set the enable/disable state of the spinbox, so it gets completely redrawn.

      Best regards,

      Florian
      Please read the forum rules before posting.

      Keep in mind, this is *not* a support forum.
      Our engineers will try to answer your questions between their projects if possible but this can be delayed by longer periods of time.
      Should you be entitled to support you can contact us via our support system: segger.com/ticket/
      Or you can contact us via e-mail.