Hell Segger Team
The manual suggests to copy all the required files into the project folder.
We
usually link a particular version of third party packages into our
projects and try to leave the original structure untouched, so that when
there is an update of the third party package, we "just" link the new
version in the hope it will compile and work out of the box.
Some suggestions:
SEGGER_SYSVIEW_Config_<RTOS-Type>.c and
SEGGER_SYSVIEW_<RTOS-Type>.c/.h in the "Sample" folder I have not
yet fully understood why these are considered samples. Are those not
ports?
Is the user meant to change the code in
SEGGER_SYSVIEW_Config_<RTOS-Type>.c? Is
SEGGER_SYSVIEW_<RTOS-Type>.c/.h also meant to be altered by the
user? Or could those files also be placed in a [/SEGGER]/ports folder?
Can anyone please point out which files are meant to be altered by the user (all the configs, I would guess) and which are SEGGER maintained only?
Kind Regards
Roman
The manual suggests to copy all the required files into the project folder.
We
usually link a particular version of third party packages into our
projects and try to leave the original structure untouched, so that when
there is an update of the third party package, we "just" link the new
version in the hope it will compile and work out of the box.
Some suggestions:
- The
name Global.h is very generic and might easily collide with a name from
a users project. All other files are named SEGGER_<something>. I
would suggest also to give that file the SEGGER_ "namespace" - SEGGER_RTT_Conf.h
and SEGGER_SYSVIEW_Conf.h are templates which can be changed by the
user. I suggest to keep them separate from h- files which are part of
the "base" code in order to have more control of the compilers -I
include paths. I suggest to rename and move Global.h into the /SEGGER
folder. - Both, SEGGER_RTT_Conf.h and SEGGER_SYSVIEW_Conf.h, have
sections that are configurable and others that have fixed defines. I
suggest to separate the user configuration part from any defines that
are rather part of the "base" code in different files from which the
user configuration files then can be copied into the users project. Can
those "fixed" defines not be placed in SEGGER_RTT.h and
SEGGER_SYSVIEW.h?
SEGGER_SYSVIEW_Config_<RTOS-Type>.c and
SEGGER_SYSVIEW_<RTOS-Type>.c/.h in the "Sample" folder I have not
yet fully understood why these are considered samples. Are those not
ports?
Is the user meant to change the code in
SEGGER_SYSVIEW_Config_<RTOS-Type>.c? Is
SEGGER_SYSVIEW_<RTOS-Type>.c/.h also meant to be altered by the
user? Or could those files also be placed in a [/SEGGER]/ports folder?
Can anyone please point out which files are meant to be altered by the user (all the configs, I would guess) and which are SEGGER maintained only?
Kind Regards
Roman