Error in DECLARE_CREATE_FROM_STREAM after editing GUI.h

JanBurg · Jun 20th 2022, 4:03pm

Dear Segger Team,

I have edited some color definitions in GUI.h. After recompilation I am now getting errors in an unexpected location.

The 24 lines under

#define DECLARE_CREATE_FROM_STREAM(ID) int GUI_CreateBitmapFromStream##ID(GUI_BITMAP * pBMP, GUI_LOGPALETTE * pPAL, const void * p);

are replaced by

const void

which produces a declaration error.
If I uncomment this whole section the compiliation runs normally.
I am not sure, however, what caused this problem after many years without it.
I am using STM32CubeIDE 1.9.0.

Best regards
Jan

SEGGER - Florian · Jun 21st 2022, 12:02pm

Hi,

By color definitions you mean the default color defines like GUI_BLUE, GUI_WHITE, and so on? I don't understand how changing these defines would have an impact on the macro that declares the streamed bitmap prototypes.

At any rate, it is not a good idea to modify the emWin source code that we ship. This can make it impossible for us to comprehend any issues that might occur.

I would suggest that you add your custom color definitions to your own header files. To create custom colors you can use the GUI_MAKE_COLOR() define which will make sure the color bits are swapped correctly in both ABGR and ARGB mode.

Best regards,
Florian

JanBurg · Jun 22nd 2022, 9:19am

Hi Florian,
I also don't believe that changing some color values caused the issue. The changes probably just triggered the recompilation of GUI.h. I replaced the file with the original unchanged GUI.h. Even then I get the same problem. It only runs when I uncomment all lines with DECLARE_CREATE_FROM_STREAM.

Regards
Jan

JanBurg · Jun 22nd 2022, 9:26am

Are the two '#' characters in
GUI_CreateBitmapFromStream##ID(GUI_BITMAP * pBMP, GUI_LOGPALETTE * pPAL, const void * p)
a possible issue for the compiler?

Jan

SEGGER - Florian · Jun 22nd 2022, 10:55am

Hi Jan,

I doubt that the tokenization feature (## in defines) is not supported by your compiler, we use a lot of different compilers to test our code and we never ran into any problems with this. Which compiler are you using?

Best regards,
Florian

JanBurg · Jun 22nd 2022, 12:17pm

Thank you for your answer. I am using STM32CubeIDE 1.9.0.

Regards
Jan

SEGGER - Florian · Jun 22nd 2022, 1:39pm

Hi Jan,

I believe STM32CubeIDE uses the GCC compiler. Does the compiler output build errors regarding this? Could you send me the errors that are output in your IDE's console window?

Thanks and best regards,
Florian

JanBurg · Jun 22nd 2022, 2:11pm

Hello Florian,

yes its GCC based. I was asking about "##" because this is the only place in my project where it occurs.

There is not much of an error shown. See attached screenshot with the faulty lines and the error messages.

Regards
Jan

SEGGER - Florian · Jun 23rd 2022, 9:05am

Hi Jan,

This is odd indeed. Also, these are by far not the only lines in the emWin code where the ## is used in defines. So it cannot be the ## alone what causes this.

But my guess is that the issue is caused by the IDE, so I would ask ST about this, maybe they already know about this issue.

Best regards,
Florian

JanBurg · Jun 23rd 2022, 10:02am

Hi Florian,

as I mentioned before the project ran without such problems for years. This year STM32CubeIDE switched to GCC 10. This was the latest change which might have caused the issue.

Regards
Jan

Share